Various UI Improvements #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've been improving the UI and WebGL rendering of the goMarkableStream application, a web client for controlling reMarkable devices. Here's what we've accomplished: UI Improvements 1. Added a modern design with: - Better typography using Inter font - Improved sidebar with better styling - Dark mode toggle with sun/moon icons - Tooltips for buttons - Better feedback with messages for user actions 2. Enhanced CSS with: - CSS variables for consistent theming - Improved animations and transitions - Better responsive design - More cohesive color scheme WebGL Rendering Fixes 1. Fixed pointer display issues by: - Simplifying the laser pointer rendering - Removing animations that caused reliability issues - Using direct coordinate mapping instead of easing - Making sure pointer is hidden correctly when off-screen 2. Fixed image clarity problems by: - Removing the sharpening filter that was causing artifacts - Reducing contrast adjustments to preserve drawing details - Simplifying the fragment shader - Enabling preserveDrawingBuffer and alpha channels Current Status We addressed two specific issues: 1. Fixed the pointer not displaying correctly 2. Fixed the drawing image losing elements and appearing unclear when resized Key Files Modified - style.css: Enhanced styling for the UI - index.html: Updated layout and added tooltips - glCanvas.js: Fixed WebGL rendering issues - uiInteractions.js: Added message feedback - utilities.js: Added helper functions The app now has a more modern UI with dark mode support and properly functioning WebGL rendering for both the pointer and drawing display.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
GoGitOps Review
Grade: A+ (98.4%)
Files: 37
Issues: 5
gofmt: 100%
go_vet: 100%
gocyclo: 97%
internal/eventhttphandler/gesture_handler.go
Line 60: warning: cyclomatic complexity 16 of function (*GestureHandler).ServeHTTP() is high (> 15) (gocyclo)
golint: 89%
internal/remarkable/device.go
Line 3: warning: exported type DeviceModel should have comment or be unexported (golint)
internal/remarkable/device.go
Line 6: warning: exported const UnknownDevice should have comment (or a comment on this block) or be unexported (golint)
internal/remarkable/fb_rm.go
Line 10: warning: exported function GetFileAndPointer should have comment or be unexported (golint)
http.go
Line 111: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
internal/remarkable/const.go
Line 6: warning: exported const Model should have comment (or a comment on this block) or be unexported (golint)
internal/remarkable/const.go
Line 15: warning: comment on exported const MaxXValue should be of the form "MaxXValue ..." (golint)
license: 100%
ineffassign: 100%
misspell: 100%
This report was generated using GoGitOps.
There was a problem hiding this comment.
GoGitOps Review
Grade: A+ (98.4%)
Files: 37
Issues: 3
gofmt: 97%
- This PR will be rejected until gofmt is 100%http.go
Line 1: warning: file is not gofmted with -s (gofmt)
go_vet: 100%
gocyclo: 97%
internal/eventhttphandler/gesture_handler.go
Line 60: warning: cyclomatic complexity 16 of function (*GestureHandler).ServeHTTP() is high (> 15) (gocyclo)
golint: 97%
internal/remarkable/const.go
Line 22: warning: exported const PenInputDevice should have comment (or a comment on this block) or be unexported (golint)
license: 100%
ineffassign: 100%
misspell: 100%
This report was generated using GoGitOps.
There was a problem hiding this comment.
GoGitOps Review
Grade: A+ (98.7%)
Files: 37
Issues: 2
gofmt: 97%
- This PR will be rejected until gofmt is 100%http.go
Line 1: warning: file is not gofmted with -s (gofmt)
go_vet: 100%
gocyclo: 97%
internal/eventhttphandler/gesture_handler.go
Line 60: warning: cyclomatic complexity 16 of function (*GestureHandler).ServeHTTP() is high (> 15) (gocyclo)
golint: 100%
license: 100%
ineffassign: 100%
misspell: 100%
This report was generated using GoGitOps.
There was a problem hiding this comment.
GoGitOps Review
Grade: A+ (99.7%)
Files: 37
Issues: 1
gofmt: 100%
go_vet: 100%
gocyclo: 97%
internal/eventhttphandler/gesture_handler.go
Line 60: warning: cyclomatic complexity 16 of function (*GestureHandler).ServeHTTP() is high (> 15) (gocyclo)
golint: 100%
license: 100%
ineffassign: 100%
misspell: 100%
This report was generated using GoGitOps.
There was a problem hiding this comment.
GoGitOps Review
Grade: A+ (99.7%)
Files: 37
Issues: 1
gofmt: 100%
go_vet: 100%
gocyclo: 97%
internal/eventhttphandler/gesture_handler.go
Line 60: warning: cyclomatic complexity 16 of function (*GestureHandler).ServeHTTP() is high (> 15) (gocyclo)
golint: 100%
license: 100%
ineffassign: 100%
misspell: 100%
This report was generated using GoGitOps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UI Improvements
A modernized and more user-friendly UI has been implemented, focusing on aesthetics, usability, and responsiveness.
WebGL Rendering Fixes
Critical fixes have been applied to address issues with pointer display and image clarity in the WebGL rendering.
preserveDrawingBufferand alpha channels for better image retention.Current Status
The following specific issues have been resolved:
Key Files Modified
style.css: Enhanced styling for the UI.index.html: Updated layout and added tooltips.glCanvas.js: Fixed WebGL rendering issues.uiInteractions.js: Added message feedback.utilities.js: Added helper functions.Summary